fix: remove stale WireUtilitiesPackage and WireFoundationSupport dependencies - WPB-25373#4574
Open
fix: remove stale WireUtilitiesPackage and WireFoundationSupport dependencies - WPB-25373#4574
Conversation
…ndencies WireUtilitiesPackage was linked in WireDomain.xcodeproj's Frameworks build phase even though nothing in WireDomain uses it. This caused ZIPFoundation symbols to be statically compiled into WireDomain.framework, duplicating symbols already present in WireSystem.framework. WireFoundationSupport was declared as a dependency of WireDomainPackageTests but is not imported in any test file. Because it is a static library that re-embeds WireFoundation symbols, it caused BackoffRetrier, LeadingTrailingDebouncer and BundleFinder to appear in both WireFoundation_PackageProduct.framework and the test bundle, triggering the duplicate-class check introduced in scripts/check_duplicate_classes.sh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Test Results 1 files 139 suites 16s ⏱️ Results for commit 4250b09. ♻️ This comment has been updated with latest results. Summary: workflow run #25480053739 |
|
netbe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
WireUtilitiesPackage was linked in WireDomain.xcodeproj's Frameworks build phase even though nothing in WireDomain uses it. This statically embedded ZIPFoundation symbols into WireDomain.framework, duplicating symbols already present in WireSystem.framework.
WireFoundationSupport was declared as a dependency of WireDomainPackageTests in Package.swift but is not imported in any test file. Being a static library that re-embeds WireFoundation symbols, it caused BackoffRetrier, LeadingTrailingDebouncer, and BundleFinder to appear in both WireFoundation_PackageProduct.framework and the test bundle at runtime.
Both duplicates are now detected and fail CI via scripts/check_duplicate_classes.sh.
Testing
Run the WireDomain tests and verify the CI check_duplicate_classes.sh step reports no duplicates.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: